[Platform] Add token usage extractor for Ollama
#1122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
changed the title
OllamaOllama and CachedPlatform
Contributor
|
Wait for #1125 |
Guikingone
force-pushed
the
refactor/token_usage
branch
from
81df5ce to
73cf241
Compare
Guikingone
changed the title
Ollama and CachedPlatformOllama
Contributor
|
#1125 is now merged |
Contributor
Author
|
Yes, need to finish the tests and ensure that stream implementation is correct, should be done tomorrow 🙂 |
Guikingone
force-pushed
the
refactor/token_usage
branch
2 times, most recently
from
0cfefc5 to
7e7903b
Compare
carsonbot
added
Bug
Contributor
Author
|
The |
OskarStark
added a commit
that referenced
this pull request
Dec 16, 2025
This PR was squashed before being merged into the main branch. Discussion ---------- [Platform] Improvements on `CachedPlatform` | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | yes | Issues | Extracted from #1122 | License | MIT Summary: - Add `MonotonicClock` as the default implementation for `ClockInterface` argument in `CachedPlatform` to ease tests and improve precision instead of `DatetimeImmutable()` - Add an alias for `CachedPlatform` - Add missing `.` in the `name` tag of `CachedPlatform` definition - Improvements on tests for arguments / tags Commits ------- 149ff59 [Platform] Improvements on `CachedPlatform`
Guikingone
force-pushed
the
refactor/token_usage
branch
from
fb0ba70 to
40b4e16
Compare
Contributor
|
Can you please add an example script? thanks |
Guikingone
force-pushed
the
refactor/token_usage
branch
from
40b4e16 to
ca9e8d4
Compare
Contributor
Author
|
@OskarStark Done, both for streaming and non-streaming calls |
Contributor
|
Thank you @Guikingone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.